[webkit-reviews] review denied: [Bug 22384] svg <text> fails to update when setting x/y : [Attachment 31027] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 08:49:13 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 22384: svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384

Attachment 31027: First attempt
https://bugs.webkit.org/attachment.cgi?id=31027&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'm pretty sure that handling this in the JS bindings is the wrong layer. Won't
that mean other language bindings, or mutation via the core C++ interfaces,
have the same bug? I think the notification should be at the core object level,
or else we need to provide a generic way to do it for all language bindings and
apply it to, for instance, the ObjC bindings.

The code itself looks fine, but r- to consider this change of approach.


More information about the webkit-reviews mailing list