[webkit-reviews] review denied: [Bug 26380] SVG Filters and big sized filterRegions : [Attachment 31267] big svg filter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 01:52:51 PDT 2009


Oliver Hunt <oliver at apple.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 26380: SVG Filters and big sized filterRegions
https://bugs.webkit.org/show_bug.cgi?id=26380

Attachment 31267: big svg filter 
https://bugs.webkit.org/attachment.cgi?id=31267&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Where does the 3000.0f maxSize come from? It looks like it's actually a
constant so i believe you actually probably want a static const float
kMaxFilterSize = 3000.0f; in the file, rather than scoped to the function.


More information about the webkit-reviews mailing list