[webkit-reviews] review denied: [Bug 25551] Support for HTML5 Forms "required" attribute : [Attachment 31141] Final patch, corrected

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 31141: Final patch, corrected
https://bugs.webkit.org/attachment.cgi?id=31141&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I'm concerned by the absence of tests for validity (i realise they're dependent
on bug #19562, but i think in that case we probably want to make this bug
depend on that one).  I actually believe that hasMissingValue is wrong for
CHECKBOX and RADIO as it appears to imply that a checked radio button or
checkbox is missing its value.