[webkit-reviews] review granted: [Bug 26479] Share code between filterEffects : [Attachment 31412] Share the code
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 18 01:11:14 PDT 2009
Oliver Hunt <oliver at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 26479: Share code between filterEffects
https://bugs.webkit.org/show_bug.cgi?id=26479
Attachment 31412: Share the code
https://bugs.webkit.org/attachment.cgi?id=31412&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
I think it makes sense to hoist
78 GraphicsContext* filterContext = getEffectContext();
79 if (!filterContext)
80 return;
to above the creation of dstRect for clarity
More information about the webkit-reviews
mailing list