[webkit-reviews] review granted: [Bug 26499] Support hardware acceleration of <video> : [Attachment 31468] Step 1 patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 26499: Support hardware acceleration of <video>
https://bugs.webkit.org/show_bug.cgi?id=26499

Attachment 31468: Step 1 patch
https://bugs.webkit.org/attachment.cgi?id=31468&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    virtual bool requiresLayer() const { return true; }
> +    virtual bool isVideo() const { return true; }

These should be private. For example, if anyone calls isVideo() on a
RenderVideo you want the compile to fail so they don't create unneeded dead
code.

Of course, most of the other virtual functions should be private too for the
same reason.

Are those extra virtual calls in isSelfPaintingLayer() getting out of hand?

r=me