[webkit-reviews] review requested: [Bug 26301] Test bug for bugzilla scripts -- see bug 26283 : [Attachment 31455] Make Settings::shouldPaintNativeControls default to true

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 17 15:58:50 PDT 2009


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 26301: Test bug for bugzilla scripts -- see bug 26283
https://bugs.webkit.org/show_bug.cgi?id=26301

Attachment 31455:	  Make Settings::shouldPaintNativeControls default to
true
https://bugs.webkit.org/attachment.cgi?id=31455&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
	Make Settings::shouldPaintNativeControls default to true

	This matches the default up in WebKit (that was changed in r43318).

	Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style
	form controls
	<https://bugs.webkit.org/show_bug.cgi?id=26493>

	Reviewed by Darin Adler and Dave Hyatt.

	No test possible since DRT always uses Mac-style form controls.

	* page/Settings.cpp: Changed the initial value of
	gShouldPaintNativeControls to true.

	* rendering/RenderThemeSafari.cpp:
	(WebCore::RenderTheme::themeForPage): Added a FIXME about the design
	flaw here involving querying Settings before it's been initialized.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44785
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 3 files changed, 26 insertions(+), 1 deletions(-)


More information about the webkit-reviews mailing list