[webkit-reviews] review denied: [Bug 26425] Small Refactoring to Consolidate Common GDI Calls : [Attachment 31453] Rev 3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 17 15:44:27 PDT 2009
Adam Roben (aroben) <aroben at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26425: Small Refactoring to Consolidate Common GDI Calls
https://bugs.webkit.org/show_bug.cgi?id=26425
Attachment 31453: Rev 3
https://bugs.webkit.org/attachment.cgi?id=31453&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
This is looking great.
Since the 4 changes are each pretty self-contained, it would be much better to
get them reviewed and landed as separate patches.
I also think the BitmapInfo functions should return a WebCore::BitmapInfo, not
a BITMAPINFO.
r- so that these changes can be split up. Thanks for the great work!
More information about the webkit-reviews
mailing list