[webkit-reviews] review denied: [Bug 26336] Some test cases in LayoutTests/editing/execCommand must be using dumpAsText tests : [Attachment 31439] converts paste-1.html paste-2.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 17 15:12:39 PDT 2009


Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 26336: Some test cases in LayoutTests/editing/execCommand must be using
dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=26336

Attachment 31439: converts paste-1.html paste-2.html
https://bugs.webkit.org/attachment.cgi?id=31439&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Tabs:
0     if (window.layoutTestController)
20	    window.layoutTestController.notifyDone();
 31		window.layoutTestController.notifyDone();

Missing newline:
2539 </script>
2640 \ No newline at end of file

Otherwise looks fine.  The tab will block checkin (the pre-commit hook will
fail).


More information about the webkit-reviews mailing list