[webkit-reviews] review cancelled: [Bug 25068] Complex text support for Chromium Linux : [Attachment 31363] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 17 14:11:48 PDT 2009


Adam Langley <agl at chromium.org> has cancelled Adam Langley <agl at chromium.org>'s
request for review:
Bug 25068: Complex text support for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=25068

Attachment 31363: patch
https://bugs.webkit.org/attachment.cgi?id=31363&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
Changes:

* Add createGlyphArrays and deleteGlyphArrays to remove some code duplication.
* Removed some enum cases where they weren't needed.
* BUG (typo): stroked complex text would crash.
* BUG (typo): LTR complex text could hit an assertion.
* BUG: highlighting an LTR complex text run wouldn't highlight the last
character.'


More information about the webkit-reviews mailing list