[webkit-reviews] review granted: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 31299] Rebased patch to tip of tree for extracting RenderThemeChromiumSkia out of RenderThemeChromiumLinux, with Eric's landing fixes. Other patches to follow.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148

Attachment 31299: Rebased patch to tip of tree for extracting
RenderThemeChromiumSkia out of RenderThemeChromiumLinux, with Eric's landing
fixes. Other patches to follow.
https://bugs.webkit.org/attachment.cgi?id=31299&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The ChangeLog is doubled.

Indent:
bool RenderThemeChromiumSkia::supportsHover(const RenderStyle* style) const
 141 {
 142   return true;
 143 }

Unused parameters can cause warnings and thus compile failures:
bool RenderThemeChromiumSkia::supportsFocusRing(const RenderStyle* style) const

155146 {
156	 return supportsFocus(style->appearance());
 147	 // This causes WebKit to draw the focus rings for us.
 148	 return false;
157149 }

Otherwise looks fine.  Someone could fix this when landing I guess.