[webkit-reviews] review requested: [Bug 26326] REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction. : [Attachment 31397] Proposed fix.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 16 21:31:24 PDT 2009
David Levin <levin at chromium.org> has asked for review:
Bug 26326: REGRESSION: When the main page (ScrollView) has a custom scrollbar,
it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Attachment 31397: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=31397&action=review
------- Additional Comments from David Levin <levin at chromium.org>
Regarding this comment "Oh, also if the scrollbars are supplied by the
ownerElement's document rather than your own, then you don't need to destroy
them either"
I should have asked in irc, but I wasn't quite sure how that translated to
code. I did my best guess by adding the renderBox check. Let me know if this
isn't correct (and hopefully what it should be).
More information about the webkit-reviews
mailing list