[webkit-reviews] review denied: [Bug 25043] Race condition in MessagePort::clone() : [Attachment 31118] revised patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 16 17:25:35 PDT 2009
David Levin <levin at chromium.org> has denied Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 25043: Race condition in MessagePort::clone()
https://bugs.webkit.org/show_bug.cgi?id=25043
Attachment 31118: revised patch
https://bugs.webkit.org/attachment.cgi?id=31118&action=review
------- Additional Comments from David Levin <levin at chromium.org>
Last comment:
> LayoutTests/fast/events/message-port-clone.html-disabled
var timer = setTimeout(function() {
log("FAIL: timeout waiting for message delivery");
done();
}, 1000);
I don't think it is necessary to set a timeout as the layout test mechanisms
will do a timeout. (I just don't want the test to fail if someone is running
it on heavily loaded machine and has adjusted the timeout in the script
accordingly.)
There enough things to address that I'm marking r- for now, but in general it
looks really good to me.
More information about the webkit-reviews
mailing list