[webkit-reviews] review granted: [Bug 26278] Patch that make WebCore have a RenderTheme per page : [Attachment 31391] Fixed as many theme() as I could find

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 26278: Patch that make WebCore have a RenderTheme per page
https://bugs.webkit.org/show_bug.cgi?id=26278

Attachment 31391: Fixed as many theme() as I could find
https://bugs.webkit.org/attachment.cgi?id=31391&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ b/WebKit/win/WebView.cpp
> @@ -1854,7 +1854,7 @@ static LRESULT CALLBACK WebViewWndProc(HWND hWnd, UINT
message, WPARAM wParam, L
>	   case WM_XP_THEMECHANGED:
>	       if (Frame* coreFrame = core(mainFrameImpl)) {
>		   webView->deleteBackingStore();
> -		   theme()->themeChanged();
> +		   RenderTheme::defaultTheme()->themeChanged();

Should this use coreFrame->page()->theme() instead?

Thanks for fixing this up!

r=me