[webkit-reviews] review denied: [Bug 26278] Patch that make WebCore have a RenderTheme per page : [Attachment 31358] Qt specific RenderTheme patch, accepted by Simon and with the RefPtr fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 16 15:30:16 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has denied 's request for review:
Bug 26278: Patch that make WebCore have a RenderTheme per page
https://bugs.webkit.org/show_bug.cgi?id=26278

Attachment 31358: Qt specific RenderTheme patch, accepted by Simon and with the
RefPtr fix.
https://bugs.webkit.org/attachment.cgi?id=31358&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
It turns out that this breaks the Windows build, due to calls to theme() that
were not corrected in this patch. It probably breaks other builds, too. Can you
grep over the WebCore/WebKit directories to find all calls to theme() and
update them?


More information about the webkit-reviews mailing list