[webkit-reviews] review requested: [Bug 20303] [Qt] Key events are not working in frames. : [Attachment 31378] new patch to include recommended changed in the comments.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 16 14:51:40 PDT 2009
Yongjun Zhang <yongjun.zhang at nokia.com> has asked for review:
Bug 20303: [Qt] Key events are not working in frames.
https://bugs.webkit.org/show_bug.cgi?id=20303
Attachment 31378: new patch to include recommended changed in the comments.
https://bugs.webkit.org/attachment.cgi?id=31378&action=review
------- Additional Comments from Yongjun Zhang <yongjun.zhang at nokia.com>
Change maded as per zecke's suggestions:
1. move scrolling handling code to EventHandler so that other ports can use it.
2. use do...while to shorten the code a bit.
More information about the webkit-reviews
mailing list