[webkit-reviews] review granted: [Bug 26278] Patch that make WebCore have a RenderTheme per page : [Attachment 31357] RenderTheme patch incorporating all comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 16 14:27:15 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 26278: Patch that make WebCore have a RenderTheme per page
https://bugs.webkit.org/show_bug.cgi?id=26278

Attachment 31357: RenderTheme patch incorporating all comments
https://bugs.webkit.org/attachment.cgi?id=31357&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> From 204628441494884d406f8d75ab90ef9589bfc1ae Mon Sep 17 00:00:00 2001
> From: Kenneth Rohde Christiansen <kenneth at spisnigel.osmtc.indt.org.br>
> Date: Tue, 16 Jun 2009 15:20:27 -0300
> Subject: [PATCH] 2009-06-16  Kenneth Rohde Christiansen 
<kenneth.christiansen at openbossa.org>
> 
>	  Reviewed by Dave Hyatt and Adam Roben.

We normally leave this line as "Reviewed by NOBODY (OOPS!)." since a different
reviewer might review a subsequent iteration of the patch.

>  class RenderThemeGtk : public RenderTheme {
> -public:
> +private:
>      RenderThemeGtk();
>      virtual ~RenderThemeGtk();
>  
> +public:
> +    static PassRefPtr<RenderTheme> create();
> +

Our style is to list public members before private members. This can be fixed
by a committer before landing.

> +    // When the theme is needed in non-page dependent code, the
defaultTheme() is used as fallback.
> +    static inline PassRefPtr<RenderTheme> defaultTheme()
> +    {
> +	   return RenderTheme::themeForPage(0);
> +    };

No need for "RenderTheme::" here.

I'll fix these issues before committing.

r=me


More information about the webkit-reviews mailing list