[webkit-reviews] review requested: [Bug 25068] Complex text support for Chromium Linux : [Attachment 31363] patch

[bugzilla-daemon at webkit.org]

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 25068: Complex text support for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=25068

Attachment 31363: patch
https://bugs.webkit.org/attachment.cgi?id=31363&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
Points not addressed in code:

> Really?
> 377	  // (Mac code ignores includePartialGlyphs, and they don't know what
it's
> 378	  // supposed to do, so we just ignore it as well.)
> ignored arguments generally cause warnings in the compiler, no?

This comment was taken from the Windows code. The ignored argument doesn't
trigger a warning for us in either place.

> I assume this is in no way temporary?
>  321	   const FontPlatformData& font =
fontDataForCharacters(run.characters(), run.length())->fontDataForCharacter('
')->platformData();

It seems to be the way to get what I need.


Cheers

AGL