[webkit-reviews] review granted: [Bug 26449] UMR in WebCore::BitStack : [Attachment 31354] v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 16 11:08:52 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tony Chang
(Google) <tony at chromium.org>'s request for review:
Bug 26449: UMR in WebCore::BitStack
https://bugs.webkit.org/show_bug.cgi?id=26449

Attachment 31354: v1
https://bugs.webkit.org/attachment.cgi?id=31354&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +2009-06-16  tony chang  <tony at chromium.org>

nit: people normally use mixed case for their names.


> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WARNING: NO TEST CASES ADDED OR CHANGED
> +	   
> +	   Fix a UMR in WebCore::BitStack by initializing new memory to 0.
> +	   https://bugs.webkit.org/show_bug.cgi?id=26449
> +	   No new tests, covered by purify.
> +

nit: please be sure to add a bug link in the ChangeLog before committing.


Otherwise, R=me


More information about the webkit-reviews mailing list