[webkit-reviews] review granted: [Bug 26427] Use consistent Windows GUID Comparison Functions : [Attachment 31331] Use IsEqualGUID

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 26427: Use consistent Windows GUID Comparison Functions
https://bugs.webkit.org/show_bug.cgi?id=26427

Attachment 31331: Use IsEqualGUID
https://bugs.webkit.org/attachment.cgi?id=31331&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    if (IID_IUnknown==riid || IID_IDataObject==riid)
> +    if (IsEqualIID(riid, IID_IUnknown) || 
> +	   IsEqualIID(riid, IID_IDataObject)) {
>	   *ppvObject=this;
> +    }

I don't think you needed to break this into multiple lines. And when you did, I
wish you had followed the WebKit coding style (see the Indentation section,
item 6, and the Braces section, item 3).

r=me