[webkit-reviews] review requested: [Bug 26326] REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction. : [Attachment 31305] Proposed fix.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has asked  for review:
Bug 26326: REGRESSION: When the main page (ScrollView) has a custom scrollbar,
it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Attachment 31305: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=31305&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I have a few concerns about my patch, but I put it together as a place to
start.

Here are my concerns:
1. I don't know if there is another function that I should call in FrameView. 
(It doesn't look like there is one.)

2. I don't know if this function should do more.  For example, ~FrameView does
resetScrollbars right before the calls to setHas*Scrollbar(false);  
Should it do even more of what ~FrameView does?

3. onDocumentDetaching doesn't seem like a great name.	detach() seemed to be
typical but I wasn't sure what that function mean in general so I didn't know
if this fit the pattern or not.