[webkit-reviews] review requested: [Bug 26146] Change to use ThreadableLoader to load the worker script in order to check URL origin for redirection. : [Attachment 31122] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 15 11:13:20 PDT 2009


Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 26146: Change to use ThreadableLoader to load the worker script in order to
check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146

Attachment 31122: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=31122&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I think Dave Levin should review this patch, but also i'm unsure what it is
trying to do -- the bug conflates changing the loader and adding origin checks,
and i'm unsure whether this effects new Worker or importScripts

The discussion i had with firefox people some time ago resulted in the
conclusion that importScripts should not have an origin check (eg. it would
behave as <script>)


More information about the webkit-reviews mailing list