[webkit-reviews] review requested: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 31297] Rebased patch to tip of tree for extracting RenderThemeChromiumSkia out of RenderThemeChromiumLinux. Other patches to follow.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 15 10:45:19 PDT 2009


Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148

Attachment 31297: Rebased patch to tip of tree for extracting
RenderThemeChromiumSkia out of RenderThemeChromiumLinux.  Other patches to
follow.
https://bugs.webkit.org/attachment.cgi?id=31297&action=review

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
The updated patch has 3 changes:

  (1) Handles the addition of systemColor into RenderThemeChromiumLinux.  This
was left in RenderThemeChromiumLinux and not put in RenderThemeChromiumSkia
because it is not shared with windows.
  (2) Moved the adding of the linux specific user agent style sheet into
RenderThemeChromiumLinux.  This required splitting the extraDefaultStyleSheet
function
  (3) Updated the patch to respect the changes to paintButtonLike.  This has no
effective changes since it is just a static function.


More information about the webkit-reviews mailing list