[webkit-reviews] review requested: [Bug 17820] fast/js/date-DST-time-cusps.html and fast/js/date-big-setdate.html fail when not in PST/PDT time zone : [Attachment 31287] Another patch v1

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 17820: fast/js/date-DST-time-cusps.html and fast/js/date-big-setdate.html
fail when not in PST/PDT time zone
https://bugs.webkit.org/show_bug.cgi?id=17820

Attachment 31287: Another patch v1
https://bugs.webkit.org/attachment.cgi?id=31287&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Alexey, thanks for your opinion. I think the patch wasn't submitted and we
don't need to revert it.

I uploaded another patch, which is more complicated than the previous patch.
This patch adds setTimezoneToPDT and setTimezoneToOriginal into
layoutTestController and uses these functions in layout tests which exercise
DST. This may make DateMath a bit slower to check if environment value TZ is
changed. I'm not sure if it's better solution for this bug.

Anyway, I'm happy if webkit accepts either of my patches. As the DST related
layout tests always fail in my timezone, I need to check the failures of date-*
manually, which is annoying...

Thanks,