[webkit-reviews] review requested: [Bug 26379] Reconsider image decoding architecture/APIs : [Attachment 31264] Take out asNativeImagePtr

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 26379: Reconsider image decoding architecture/APIs
https://bugs.webkit.org/show_bug.cgi?id=26379

Attachment 31264: Take out asNativeImagePtr
https://bugs.webkit.org/attachment.cgi?id=31264&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Proposal to take out the asNativeImagePtr from RGBA32Buffer and move it to skia
specific files.

The name "RGBA32Buffer" indicates that the secret of the class is to hold a
buffer for RGBA8888 pixel manipulation, I don't think the class should know how
to construct a image, someone else should know how to turn the buffer into a
NativeImage...

The only #ifdef's left in the code are for Skia header files and members and
there is nothing at this point we can do to avoid that. So I will stop here.