[webkit-reviews] review denied: [Bug 15189] REGRESSION (Safari 2->3?): should support oninput event : [Attachment 31249] Adds support for oninput attribute as well as dispatching of the event.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied 's request for review:
Bug 15189: REGRESSION (Safari 2->3?): should support oninput event
https://bugs.webkit.org/show_bug.cgi?id=15189

Attachment 31249: Adds support for oninput attribute as well as dispatching of
the event.
https://bugs.webkit.org/attachment.cgi?id=31249&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't think that it's appropriate to land this without better test coverage.
The discussion above suggests many tests that we could add:
- test other input types (e.g. single line inputs, radio buttons);
- test the event's behavior with SELECT elements;
- test that programmatic manipulation doesn't fire the event;
- test that keypresses that don't change the value (such as hitting the
"delete" key in an empty text field, or replacing some text in the field with
text from the clipboard that happens to be exactly the same text) don't fire
the event;
- test that the event is not dispatched too often, as in Opera.

Furthermore, HTML5 says that the event should be dispatched asynchronously, not
synchronously - and it even says that multiple events should be coalesced.