[webkit-reviews] review requested: [Bug 26371] SVGLangSpace duplicates xml:lang and xml:space values : [Attachment 31239] First attempt

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 26371: SVGLangSpace duplicates xml:lang and xml:space values
https://bugs.webkit.org/show_bug.cgi?id=26371

Attachment 31239: First attempt
https://bugs.webkit.org/attachment.cgi?id=31239&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
Here is an enhancement for SVGLangSpace. Note that FF, Opera and Batik do not
seem to know the js
attributes xmllang and xmlspace at all, so it is hard to compare. Also really
exceptions should be thrown when the attribute is set, but I think due to a bug
that objC interfaces can't handle the idl setting of raises exception, that
that may depend on another bug. I dont think this fixes a big issue but the old
implementation wasted memory and processing time IMHO. All tests still pass,
also because we do not really test these attributes except for one SVG text
test.
Cheers,

Rob.