[webkit-reviews] review requested: [Bug 25709] Skia changes to image decoders should be merged into the cross-platform ones : [Attachment 31237] Free ImageDecoder.h from any knowledge about graphics libraries (2nd attempt)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 13 08:05:18 PDT 2009


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 25709: Skia changes to image decoders should be merged into the
cross-platform ones
https://bugs.webkit.org/show_bug.cgi?id=25709

Attachment 31237: Free ImageDecoder.h from any knowledge about graphics
libraries (2nd attempt)
https://bugs.webkit.org/attachment.cgi?id=31237&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Sorry darin to have wasted your time. This patch adds the sizeof(PixelData)
instead of the magic number, changes the c cast to c++ reinterpret_cast and
adds one of the two bytes() symbols back to ImageDecoder.h. This should fix the
hidden Wx build bustage as well.


More information about the webkit-reviews mailing list