[webkit-reviews] review granted: [Bug 25709] Skia changes to image decoders should be merged into the cross-platform ones : [Attachment 31234] Free ImageDecoder.h from any knowledge about graphics libraries

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 25709: Skia changes to image decoders should be merged into the
cross-platform ones
https://bugs.webkit.org/show_bug.cgi?id=25709

Attachment 31234: Free ImageDecoder.h from any knowledge about graphics
libraries
https://bugs.webkit.org/attachment.cgi?id=31234&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    return cairo_image_surface_create_for_data((unsigned
char*)buffer->bytes().data(),
> +						  CAIRO_FORMAT_ARGB32,
> +						  size().width(),
> +						  size().height(),
> +						  size().width()*4);

Any reason to use a C-style cast here instead of the C++-style casts in the old
code? Also, why the hardcoded "4" instead of sizeof(PixelData)?

r=me