[webkit-reviews] review requested: [Bug 25939] [GTK] Text attachments in bugzilla are downloaded instead of being opened : [Attachment 31233] Don't bailout if content-type is text/plain so we can setup the headers correctly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 13 06:40:39 PDT 2009
Jan Alonzo <jmalonzo at gmail.com> has asked for review:
Bug 25939: [GTK] Text attachments in bugzilla are downloaded instead of being
opened
https://bugs.webkit.org/show_bug.cgi?id=25939
Attachment 31233: Don't bailout if content-type is text/plain so we can setup
the headers correctly
https://bugs.webkit.org/attachment.cgi?id=31233&action=review
------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
We should only bail out of the got-headers callback if the content is not
modified and we don't have a content-type. At the moment we are also bailing
out if content-type is text/plain, hence we don't get to setup the headers
correctly for text/plain data.
I've stumbled on this while trying to enable more tests in
http/tests/navigation. I've also removed a couple more tests and can probably
serve as tests for this patch.
I've tested with the launcher and works fine and can view text/plain now :)
More information about the webkit-reviews
mailing list