[webkit-reviews] review granted: [Bug 26367] Remove the globals from bidi.cpp : [Attachment 31229] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 26367: Remove the globals from bidi.cpp
https://bugs.webkit.org/show_bug.cgi?id=26367

Attachment 31229: Patch
https://bugs.webkit.org/attachment.cgi?id=31229&action=review

------- Additional Comments from mitz at webkit.org
> +    if (lBreak.obj && lineMidpointState.m_numMidpoints &&
lineMidpointState.m_numMidpoints % 2 == 0) {

The style guidelines say you should avoid == 0 and use
!(lineMidpointState.m_numMidpoints % 2).

> +	   if (lineMidpointState.m_numMidpoints % 2 == 1) {

Here you can just omit the == 1.

> -	       chopMidpointsAt(lBreak.obj, lBreak.pos-2);
> +	       chopMidpointsAt(lineMidpointState, lBreak.obj, lBreak.pos-2);

Please add spaces around the -.

r=me assuming layout tests pass. This code is kinda hot so it would be good to
verify that any changes do not cause a perf regression.