[webkit-reviews] review granted: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 31219] subRegion Code

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 19991: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Attachment 31219: subRegion Code
https://bugs.webkit.org/attachment.cgi?id=31219&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok, two things left to fix.

We label all virtual functions with "virtual" even if it's not strictly
required by C++ for subclasses.

I think:
+	 FloatRect unionOfChildEffectSubRegions(Filter*, FilterEffect*,
FilterEffect*);
+	 FloatRect unionOfChildEffectSubRegions(Filter*, FilterEffect*);
should be called:
uniteChildEffectSubRegions() (yes, that's the same name as the virtual
function, I know) since they do something/calculate something they should start
with a verb.

I don't need to see this again.  please fix the above when landing.

Thanks again!