[webkit-reviews] review denied: [Bug 26356] Need v8 bindings for DOM Storage : [Attachment 31215] v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 12 15:20:32 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 26356: Need v8 bindings for DOM Storage
https://bugs.webkit.org/show_bug.cgi?id=26356

Attachment 31215: v2
https://bugs.webkit.org/attachment.cgi?id=31215&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +    String name = ToWebCoreString(v8Name);
> +    String value = ToWebCoreString(v8Value);

toWebCoreString, sorry -- should've noticed earlier.

> +    String name = ToWebCoreString(v8Name);

ditto.


More information about the webkit-reviews mailing list