[webkit-reviews] review granted: [Bug 26353] Incorrect Handling of Cairo Fonts : [Attachment 31212] First Iteration Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 12 14:00:26 PDT 2009
Eric Seidel <eric at webkit.org> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 26353: Incorrect Handling of Cairo Fonts
https://bugs.webkit.org/show_bug.cgi?id=26353
Attachment 31212: First Iteration Patch
https://bugs.webkit.org/attachment.cgi?id=31212&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Style:
FontCustomPlatformData(const FontCustomPlatformData& source)
40 : m_fontFace(cairo_font_face_reference(source.m_fontFace))
41 {}
officially that should be:
FontCustomPlatformData(const FontCustomPlatformData& source)
: m_fontFace(cairo_font_face_reference(source.m_fontFace))
{
}
At least that's my understanding of the WK style.
Looks OK I guess.
More information about the webkit-reviews
mailing list