[webkit-reviews] review requested: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 31203] subRegion Code

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 19991: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Attachment 31203: subRegion Code
https://bugs.webkit.org/attachment.cgi?id=31203&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
> r- for the nits above.
Most things are fixed. There is no enclosingIntSize. I had to use
enclosingInRect and use the size of this rect. subRegion() is a FloatRect and
can't be used with ImageBuffer.

> I woudl really like to see a way to get rid of all the 
> calculateUniteEffectRect
> copy/paste code.
I shared as much code as possible in two new functions in FilterEffect. There
are still some effects, that need special code to calculate their subRegions.

> Does your test cover this?
Yes. The tests test clipped effects too.

> It's really getting time to retire this bug.
This is the last topic. Every following patch gets a new bug report.