[webkit-reviews] review granted: [Bug 25599] [GTK] Enable more tests : [Attachment 30076] Implement dumpStatusCallbacks and enable the only test that uses it.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 12 05:14:24 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 25599: [GTK] Enable more tests
https://bugs.webkit.org/show_bug.cgi?id=25599

Attachment 30076: Implement dumpStatusCallbacks and enable the only test that
uses it.
https://bugs.webkit.org/attachment.cgi?id=30076&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
>  
> +static void webViewStatusBarTextChanged(WebKitWebView* view, const gchar*
message, gpointer data)
> +{
> +    if (gLayoutTestController->dumpStatusCallbacks())
> +	   printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", message ?
message : "");
> +}

Looks good. Just curious: are we expecting message to be null?

r=me.


More information about the webkit-reviews mailing list