[webkit-reviews] review denied: [Bug 15135] REGRESSION (r19843-r19850): Changing a flexbox's contents makes its container scroll to the top : [Attachment 31156] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 12 01:20:09 PDT 2009


Dave Hyatt <hyatt at apple.com> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's contents makes its
container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135

Attachment 31156: Patch v1
https://bugs.webkit.org/attachment.cgi?id=31156&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You cannot add any member variables to RenderBlock, as this will significantly
bloat the size of the render tree for real world HTML.	Doing so just to fix
flexbox bugs is not a good real-world tradeoff.

I believe you can maybe just set a flag to avoid doing the work you refactored
into repaintBlockAfterLayout in the case where an object is going to do double
layouts because of flexing.


More information about the webkit-reviews mailing list