[webkit-reviews] review granted: [Bug 25609] [GTK] Implement support for get_selection and get_n_selections : [Attachment 31153] getselectionfix.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 25609: [GTK] Implement support for get_selection and get_n_selections
https://bugs.webkit.org/show_bug.cgi?id=25609

Attachment 31153: getselectionfix.patch
https://bugs.webkit.org/attachment.cgi?id=31153&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>	  This is pretty hacky-ish, but I can't seem to find a direct API to
>	  get the VisibleSelection for a given object, only the global one.

This should go as a comment in the code (as well?), IMO.
> +
> +    if (selection_num != 0 || !selectionBelongsToObject(coreObject,
selection)) {
>	   // WebCore does not support multiple selection, so anything but 0
does not make sense for now.

Probably here, extending this comment. I'd also move this comment to before the
if, so that it is clear that you are talking about the whole conditional.

Other than that, despite being hacky, this looks good.