[webkit-reviews] review requested: [Bug 25709] Skia/Cairo image decoders should be merged : [Attachment 31183] part seven

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 11 17:38:44 PDT 2009


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 25709: Skia/Cairo image decoders should be merged
https://bugs.webkit.org/show_bug.cgi?id=25709

Attachment 31183: part seven
https://bugs.webkit.org/attachment.cgi?id=31183&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This patch makes the Cairo and Skia ImageDecoder.h implement the same public
APIs, so the decoders can be the same files.

The _will_ break Qt/GTK+/anybody else who is pulling in ImageDecoder.h and
isn't Cairo.  I will abstract the Cairo- (and Skia-) specific bits back out in
the next patch or two, although these ports might still need architectural
changes.


More information about the webkit-reviews mailing list