[webkit-reviews] review granted: [Bug 26332] Upstream V8Helpers : [Attachment 31177] patch3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 11 16:40:44 PDT 2009


David Levin <levin at chromium.org> has granted Nate Chapin <japhet at google.com>'s
request for review:
Bug 26332: Upstream V8Helpers
https://bugs.webkit.org/show_bug.cgi?id=26332

Attachment 31177: patch3
https://bugs.webkit.org/attachment.cgi?id=31177&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Looks good.  I'll do the following on landing.

> +    // Get V8Proxy object from an NPObject.
Let's delete this comment as it doesn't seem to add anything.

> +    WebCore::V8Proxy* toV8Proxy(NPObject*);
Remove WebCore::


More information about the webkit-reviews mailing list