[webkit-reviews] review requested: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 31152] subRegion Code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 11 00:04:17 PDT 2009


Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 19991: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Attachment 31152: subRegion Code
https://bugs.webkit.org/attachment.cgi?id=31152&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
The same subRegion code and tests as above. Clipping of the sourceInput was
added, to avoid big ImageBuffers for SourceGraphic, SourceAlpha, ... . The
ImageBuffer still can get to big for CI if filterRegion _and_ the boundingBox
of the referenced object is very big. We may need a workaround for this case to
enable filtery by default.

This is the last patch I want to add to this bug report. I think this should
get into this report because it is necessary to get filters for SVG working.
Every following bug/addition will go into a new report and we can close this
one as well as #19835.


More information about the webkit-reviews mailing list