[webkit-reviews] review granted: [Bug 26281] REGRESSION: Copying from TextEdit/OmniGraffle and pasting into editable region loses images : [Attachment 31124] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 26281: REGRESSION: Copying from TextEdit/OmniGraffle and pasting into
editable region loses images
https://bugs.webkit.org/show_bug.cgi?id=26281

Attachment 31124: patch
https://bugs.webkit.org/attachment.cgi?id=31124&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
r=me.  Can we please please fix all that copy/paste code in that function in a
follow-up patch?  It's so disgusting!  A single static function which took a
PboardType and returned a fragment would get rid of *all* those stupid lines!

Heck, we could even make it just an Array of Pboard types so that the preferred
order was much easier to read and this kind of bug wouldn't happen again. ;)

Oh, and it should be possible to make a test for this...  Admittedly, kinda
hard, but I would expect event.dataTransfer.setData() to be able to test this.