[webkit-reviews] review granted: [Bug 25709] Skia/Cairo image decoders should be merged : [Attachment 31123] part five

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 10 00:34:48 PDT 2009


Eric Seidel <eric at webkit.org> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 25709: Skia/Cairo image decoders should be merged
https://bugs.webkit.org/show_bug.cgi?id=25709

Attachment 31123: part five
https://bugs.webkit.org/attachment.cgi?id=31123&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Shouldn't we add some ASSERTS?
128	    // NOTE: This function does not sanity-check its arguments! 
Callers
 129	     // MUST not pass invalid values or this will corrupt memory.
 130	     void copyRowNTimes(int startX, int endX, int startY, int endY)
 131	     {
 132	       const int rowBytes = (endX - startX) * sizeof uint32_t;
 133	       const uint32_t* const startAddr = m_bitmap.getAddr32(startX,
startY);
 134	       for (int destY = startY + 1; destY < endY; ++destY)
 135		   memcpy(m_bitmap.getAddr32(startX, destY), startAddr,
rowBytes);
 136	     }

also, the indent is off.

Looks sane to me.  r=me with more ASSERTs.


More information about the webkit-reviews mailing list