[webkit-reviews] review granted: [Bug 26265] add Android platform-specific files to WebCore/platform (part 8) : [Attachment 31106] patch set 1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Feng Qian <feng at chromium.org>'s
request for review:
Bug 26265: add Android platform-specific files to WebCore/platform (part 8)
https://bugs.webkit.org/show_bug.cgi?id=26265

Attachment 31106: patch set 1
https://bugs.webkit.org/attachment.cgi?id=31106&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This probably should have a notImplemented() call:
+    // Needed for PageCache, which we currently have disabled.
+    return 0.0F;

I'm also surprised to see an F there instead of an 'f'.  I didn't even know F
was valid.


+    // FIXME: use m_frame instead?
+    if (!platformWidget())
+	 return IntRect(0, 0, 0, 0);
IntRect() is the same

Looks fine.  Please fix those nits when landing.