[webkit-reviews] review granted: [Bug 26146] Change to use ThreadableLoader to load the worker script in order to check URL origin for redirection. : [Attachment 31122] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 18:55:58 PDT 2009


Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 26146: Change to use ThreadableLoader to load the worker script in order to
check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146

Attachment 31122: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=31122&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
LGTM, with one question:

> +   
request.setHTTPOrigin(scriptExecutionContext->securityOrigin()->toString());

I still don't understand this line of code.  Where in
http://www.whatwg.org/specs/web-workers/current-work/ does it say to send the
Origin header?	Usually, we send the Origin header for POST requests and
requests generated from cross-origin XMLHttpRequests.


More information about the webkit-reviews mailing list