[webkit-reviews] review granted: [Bug 25709] Skia/Cairo image decoders should be merged : [Attachment 31112] part four
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 9 18:13:24 PDT 2009
Eric Seidel <eric at webkit.org> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 25709: Skia/Cairo image decoders should be merged
https://bugs.webkit.org/show_bug.cgi?id=25709
Attachment 31112: part four
https://bugs.webkit.org/attachment.cgi?id=31112&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane enough to me.
Nits:
indent:
if (clientptr) {
521 if (!clientptr->sizeNowAvailable(screen_width, screen_height))
522 return false;
523 }
buffer.setRect(IntRect(0, 0, size().width(), size().height()));
setRect(IntRect(IntPoint(), size())) would be more concise.
More information about the webkit-reviews
mailing list