[webkit-reviews] review requested: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 31119] Remove common code from RenderThemeChromiumWin
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 9 17:56:08 PDT 2009
Albert J. Wong <ajwong at chromium.org> has asked for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148
Attachment 31119: Remove common code from RenderThemeChromiumWin
https://bugs.webkit.org/attachment.cgi?id=31119&action=review
------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
Reviewing this one is going to be the difficult one.
The 2 checks I did was as follows:
1) Verify that all functions in RenderThemeChromiumSkia were in the original
RenderThemeChromiumWin.
2) Verify that all removed functions from RenderThemeChromiumWin were
identical to the Skai versions.
For check #1, I found two functions that slipped through last time.
supportsControlTint -> Moved to RenderThemeChromiumLinux
platformTextSearchHighlightColor -> This isn't in RenderTheme. Removed.
More information about the webkit-reviews
mailing list