[webkit-reviews] review granted: [Bug 22891] Scrolling in Windows Cairo Broken if no background color set. : [Attachment 31100] Revision based on Eric's review comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 11:14:22 PDT 2009


Eric Seidel <eric at webkit.org> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 22891: Scrolling in Windows Cairo Broken if no background color set.
https://bugs.webkit.org/show_bug.cgi?id=22891

Attachment 31100: Revision based on Eric's review comments.
https://bugs.webkit.org/attachment.cgi?id=31100&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
extra space:
 80 static void fillWithClearColor (HBITMAP bitmap)

and here:
 93	    m_data->cr = createCairoContextWithHDC (dc, hasAlpha);

I really don't know what this all does.  But it seems sane enough.  Ideally
someone with Cairo knowledge would review this, but I'm not sure we have any of
those... at least any who would have time.

Looks sane enough.  Please fix the nits when landing.


More information about the webkit-reviews mailing list