[webkit-reviews] review denied: [Bug 26104] [GTK] Make NetworkRequest a proper GObject and expose SoupMessage : [Attachment 30944] Make WebKitNetworkRequest a proper GObject

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 07:31:07 PDT 2009


Xan Lopez <xan.lopez at gmail.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 26104: [GTK] Make NetworkRequest a proper GObject and expose SoupMessage
https://bugs.webkit.org/show_bug.cgi?id=26104

Attachment 30944: Make WebKitNetworkRequest a proper GObject
https://bugs.webkit.org/attachment.cgi?id=30944&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Two general comments:

- I think we should not fail to construct the object with invalid URIs, but set
it anyway (with no message), and later on WebKit build our ResourceRequests
from the URI when the message is not present in the WebKitNetworkRequest
object.

- Also, just giving a warning when both URI nad message are passed (checked in
a 'constructed' handler) is enough, no need to fail. The SoupMessage will have
priority over the URI when both are present.


More information about the webkit-reviews mailing list