[webkit-reviews] review granted: [Bug 26104] [GTK] Make NetworkRequest a proper GObject and expose SoupMessage : [Attachment 30943] Refactor handling of the SoupMessage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 07:28:46 PDT 2009


Xan Lopez <xan.lopez at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 26104: [GTK] Make NetworkRequest a proper GObject and expose SoupMessage
https://bugs.webkit.org/show_bug.cgi?id=26104

Attachment 30943: Refactor handling of the SoupMessage
https://bugs.webkit.org/attachment.cgi?id=30943&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Looks good to me. The only comment is that I'd name
ResourceRequest::setSoupMessage something like
ResourceRequest::setFromSoupMessage, which better explains what the function
actually does. r+ me with a change like that.


More information about the webkit-reviews mailing list