[webkit-reviews] review granted: [Bug 26230] JavascriptURL as frame src crasher. : [Attachment 31066] Patch with tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 8 18:14:07 PDT 2009


Eric Seidel <eric at webkit.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 26230: JavascriptURL as frame src crasher.
https://bugs.webkit.org/show_bug.cgi?id=26230

Attachment 31066: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=31066&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The question which remains to be answered is if this is the right place to do
this cancelRequests.  Clearly either the destructor should
ASSERT(!m_requestCount) or it should cancel any pending requests.

I think this looks OK to me.  Please yell, any of you CC'd loader folks, if you
disagree.


More information about the webkit-reviews mailing list